[Bug 676739] Make stream changes using input-selector/playbin2 instantaneous

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=676739
  GStreamer | gst-plugins-base | unspecified

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #215141|none                        |needs-work
             status|                            |

--- Comment #17 from Sebastian Dröge <slomo at circular-chaos.org> 2012-05-29 09:18:00 UTC ---
Review of attachment 215141:
 --> (https://bugzilla.gnome.org/review?bug=676739&attachment=215141)

::: plugins/elements/gstinputselector.c
@@ +766,3 @@
+      clock = gst_element_get_clock (GST_ELEMENT_CAST (sel));
+      if (clock)
+        cur_running_time = gst_clock_get_time (clock);

You need to take the element's base time into account here. A buffer of running
time T is to be shown if base_time + clock_time reaches T. So you need to
subtract the base_time from the clock time here (and make sure that the clock
time is larger than the base time, otherwise just use 0).

@@ +1590,3 @@
     /* schedule a new segment push */
+    if (self->sync_streams
+        && self->sync_mode == GST_INPUT_SELECTOR_SYNC_MODE_CLOCK)

Why is this only done in clock sync-mode?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.