[Bug 680998] [wavenc] TOC support

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=680998
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #221772|none                        |needs-work
             status|                            |

--- Comment #11 from Sebastian Dröge <slomo at circular-chaos.org> 2012-10-14 08:51:06 UTC ---
Review of attachment 221772:
 --> (https://bugzilla.gnome.org/review?bug=680998&attachment=221772)

Looks almost ready except

::: gst/wavenc/gstwavenc.c
@@ +714,3 @@
+  ncues = g_list_length (list);
+  cues = g_new (struct cue_point, ncues);
+  cues_size += (ncues * sizeof (struct cue_point));

This is not safe, sizeof(struct cue_point) can be different from what you think
because of struct padding. Calculate the sizeof manually

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.