[Bug 685637] [PATCH] [audioresample] Performance improvements & ARM NEON support

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=685637
  GStreamer | gst-plugins-base | 1.0.0

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #225970|none                        |needs-work
             status|                            |

--- Comment #10 from Sebastian Dröge <slomo at circular-chaos.org> 2012-10-14 09:13:09 UTC ---
Review of attachment 225970:
 --> (https://bugzilla.gnome.org/review?bug=685637&attachment=225970)

::: configure.ac
@@ +207,3 @@
+                 #include <arm_neon.h>
+                 int32x4_t testfunc(int16_t *a, int16_t *b) {
+                     return vmull_s16(vld1_s16(a), vld1_s16(b));

I don't think there should be a configure parameter for this. Just check if the
opcodes can be used and use them if they can be used

::: gst/audioresample/resample.c
@@ +556,3 @@
     }
     sum = accum[0] + accum[1] + accum[2] + accum[3];
+#if defined(OVERRIDE_INNER_PRODUCT_DOUBLE) && defined(_USE_SSE2)

No neon optimizations for inner product double and the interpolations?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.