[Bug 686829] New: [PATCH] [opus] Invalid gst_buffer_unmap() call occurs with NULL buffers

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=686829
  GStreamer | gst-plugins-bad | 1.0.0

           Summary: [PATCH] [opus] Invalid gst_buffer_unmap() call occurs
                    with NULL buffers
    Classification: Platform
           Product: GStreamer
           Version: 1.0.0
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: dv at pseudoterminal.org
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=227207)
 View: https://bugzilla.gnome.org/attachment.cgi?id=227207
 Review: https://bugzilla.gnome.org/review?bug=686829&attachment=227207

This patch corrects the buffer unmap check

The following pipeline reproduces the problem:

gst-launch-1.0 audiotestsrc ! opusenc ! rtpgstpay ! identity
drop-probability=0.2 ! queue ! rtpjitterbuffer do-lost=true mode=0 !
rtpgstdepay ! opusdec plc=true ! fakesink

If PLC is turned on, the code tries to unmap a buffer that was not mapped in
the first place. The reason for this is an erronous check in
opus_dec_chain_parse_data() if unmapping can be done or not. It tests for
buffer == NULL, but not for a buffer size of 0.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.