[Bug 683920] rmdemux can not set caps on its own pad

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=683920
  GStreamer | gst-plugins-ugly | 0.11.x

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
                 CC|                            |t.i.m at zen.co.uk
         Resolution|                            |OBSOLETE
   Target Milestone|HEAD                        |NONE

--- Comment #3 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2012-09-14 07:42:16 UTC ---
This was fixed ages ago as far as I can tell, it's even included in the 0.11.93
release from August:


commit 1c07373c2bfccef2dd289177e52ceb97003b6d43
Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Wed Jul 18 16:46:46 2012 +0100

    rmdemux: set/send caps after activating the source pads

    Makes sure the caps event isn't dropped immediately.

diff --git a/gst/realmedia/rmdemux.c b/gst/realmedia/rmdemux.c
index 28481a4..6fde1f4 100644
--- a/gst/realmedia/rmdemux.c
+++ b/gst/realmedia/rmdemux.c
@@ -1479,7 +1479,6 @@ gst_rmdemux_add_stream (GstRMDemux * rmdemux,
GstRMDemuxStream * stream)

     gst_pad_use_fixed_caps (stream->pad);

-    gst_pad_set_caps (stream->pad, stream_caps);
     gst_pad_set_event_function (stream->pad,
         GST_DEBUG_FUNCPTR (gst_rmdemux_src_event));
     gst_pad_set_query_function (stream->pad,
@@ -1488,6 +1487,7 @@ gst_rmdemux_add_stream (GstRMDemux * rmdemux,
GstRMDemuxStream * stream)
     GST_DEBUG_OBJECT (rmdemux, "adding pad %s with caps %" GST_PTR_FORMAT
         ", stream_id=%d", GST_PAD_NAME (stream->pad), stream_caps,
stream->id);
     gst_pad_set_active (stream->pad, TRUE);
+    gst_pad_set_caps (stream->pad, stream_caps);
     gst_element_add_pad (GST_ELEMENT_CAST (rmdemux), stream->pad);
     gst_pad_push_event (stream->pad, gst_event_new_stream_start ());

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.