[Bug 684251] New: deinterlace: Bug in logic in _output_frame causing incorrect behaviour?

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=684251
  GStreamer | gst-plugins-good | git

           Summary: deinterlace: Bug in logic in _output_frame causing
                    incorrect behaviour?
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: robert.swain at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


<superdump> ds: so thaytan has hit an issue with a back to the future DVD menu
with deinterlace in playbin2
<superdump> ds: i've tried to look at the issue but some of the changes made a
while ago to make it actually work properly are rather confusing
<superdump> ds: specifically commit 0446787e
<superdump> ds: the problematic part is:
http://cgit.freedesktop.org/gstreamer/gst-plugins-good/tree/gst/deinterlace/gstdeinterlace.c#n1841
<superdump> ds: when you added that check, you didn't add a comment noting what
the check means and i can't figure it out without really diving back into
deinterlace
<superdump> ds: so... please verify that check is correct and then consider
this log, ignoring timestamps: http://noraisin.net/gst/gst-deinterlace.log.gz
(thaytan: please leave it up if you can)
<superdump> (i say ignoring timestamps because thaytan found a bug with the
field duration that was screwing that up)
<superdump> ds: the problem seems to be that an interlaced frame is received
(thus adding two field to the history and cur_field_idx gets incremented to 1)
then the top field is processed (decrementing the cur_field_idx to 0) and then
instead of also deinterlacing the bottom field, this check is hit and
output_frame exits
»» superdump should have put all that in a bug report
<thaytan> superdump: there's still time!

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.