[Bug 684339] New: shm: use SOCK_CLOEXEC where appropriate in shmpipe

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=684339
  GStreamer | gst-plugins-bad | 0.10.22

           Summary: shm: use SOCK_CLOEXEC where appropriate in shmpipe
    Classification: Platform
           Product: GStreamer
           Version: 0.10.22
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: blake.tregre at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=224682)
 View: https://bugzilla.gnome.org/attachment.cgi?id=224682
 Review: https://bugzilla.gnome.org/review?bug=684339&attachment=224682

patch to add CLOEXEC in sp_client_open

shmpipe.c provides two functions which open sockets, one for shmsrc, a reader,
and one for shmsink, a writer.  sp_client_open opens a socket but doesn't set
CLOEXEC, so i've provided an '#if defined' version which uses SOCK_CLOEXEC if
it's defined and otherwise uses fnctl and O_CLOEXEC.  sp_writer_create opens
the socket for the writer and sets CLOEXEC, but it doesn't make use of
SOCK_CLOEXEC, which can lead to a race condition.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.