[Bug 684658] GstVideoDecoder locking: stuck on shutdown with mewmew.mkv and assrender

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=684658
  GStreamer | gst-plugins-base | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|blocker                     |major

--- Comment #5 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2012-09-24 10:47:52 UTC ---
Ok, pushed this for now:

 commit 62c111f1e481f558e9d65a8eface9877178d3051
 Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
 Date:   Mon Sep 24 10:16:09 2012 +0100

    videodecoder: don't take STREAM_LOCK on upstream events

    Don't try to take STREAM_LOCK on upstream events such as QOS.
    Protect qos-related variables with object lock instead. Fixes
    possible deadlock when shutting down in certain situations.

    https://bugzilla.gnome.org/show_bug.cgi?id=684658

There's another place that needs fixing, namely the GST_QUERY_CONVERT code
path, it also shouldn't take the stream lock, but I'll leave that for another
time. Keeping bug open for that.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.