[Bug 684832] videodecoder: Takes stream lock in query function

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=684832
  GStreamer | gst-plugins-base | 1.0.0

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #225183|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge <slomo at circular-chaos.org> 2012-09-26 07:01:18 UTC ---
Review of attachment 225183:
 --> (https://bugzilla.gnome.org/review?bug=684832&attachment=225183)

Looks good in general, please push after addressing:

::: gst-libs/gst/video/gstvideodecoder.c
@@ -2640,3 @@
   state = _new_output_state (fmt, width, height, reference);

-  GST_VIDEO_DECODER_STREAM_LOCK (decoder);

I'm pretty sure set_output_state() should also be protected by the stream lock.

@@ +2842,3 @@
   klass = GST_VIDEO_DECODER_GET_CLASS (decoder);

+  GST_OBJECT_LOCK (decoder);

And the same for negotiate_default()

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.