[Bug 684809] proxypad don't hold a ref to their internal pad while streaming through it

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Sep 27 01:52:04 PDT 2012


https://bugzilla.gnome.org/show_bug.cgi?id=684809
  GStreamer | gstreamer (core) | 1.0.0

--- Comment #8 from Wim Taymans <wim.taymans at gmail.com> 2012-09-27 08:51:58 UTC ---
(In reply to comment #7)
> It's not probe specific, I can reproduce it without a probe.. just add some
> another element/pad after and remove the ghostpad while the thread is blocked
> there.

It should also happen when you just remove a ghostpad (at the right time) while
things are streaming.

> I'm not a big fan of taking a ref inside gst_pad_push(), I think everyone who
> calls a method on a GObject should make sure it holds a ref to it until the
> function returns.

Let's do this for now in the ghostpads as well, then. All the event and query
forward functions already take a ref on the pad so I think the ghostpads is the
only place left where things can go wrong.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list