[Bug 684312] rtspsrc: mutex blocks going to NULL state

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=684312
  GStreamer | gst-plugins-good | 0.10.31

--- Comment #9 from Aleix Conchillo Flaqué <aleix at oblong.com> 2012-09-27 19:22:13 UTC ---
Created an attachment (id=225282)
 View: https://bugzilla.gnome.org/attachment.cgi?id=225282
 Review: https://bugzilla.gnome.org/review?bug=684312&attachment=225282

do not change state to PLAYING if in the middle of another state change

I didn't see another way to do this it solves the deadlock when going to NULL
state. Not sure if this will cause any side effects. So far, it's working fine
with a stress test of opening/closing rtspsrc continuously.

>From the commit log:

   * gst/rtsp/gstrtspsrc.c (gst_rtspsrc_play): state change might be
      happening in the application thread, so we don't change the state to
      PLAYING in the gstrtspsrc thread unless it is safe.

      A specific case is when chaning the state to NULL from the application
      thread. This will synchronously try to stop the task (with the element
      state lock acquired), but we will try a gst_element_set_state from
      gstrtspsrc thread which will block on the element state lock causing a
      deadlock.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.