[Bug 678301] audioringbuffer: introspection fixes and API clean up for bindings

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=678301
  GStreamer | gst-plugins-base | git

--- Comment #18 from Evan Nemerson <evan at coeus-group.com> 2012-09-27 23:39:58 UTC ---
(In reply to comment #17)
> Too late I guess. Still don't think the patch is entirely right.

Oh well.  If it's not right I don't mind changing it, I just need to know where
I should be freeing the data.  Of course now I'll have to add a
gst_audio_ring_buffer_set_callback_full or similar.

> Do you still need a variant with GDestroyNotify, or was it mostly for
> completeness/correctness? (I doubt anyone is going to need to use this API from
> a binding any time soon).

It's required if that functionality is required.  I can't speak to the
likelihood of the API being used from bindings.

As it was the function would simply have been skipped, but since I created that
patch Olivier Crête added (scope async) to the user_data argument, which means
that the callback is expected to be called exactly once (less than once will
leak the user data, more than once will double-free).  My understanding is that
that is false, but if not then my patch is no longer required.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.