[Bug 681678] Port to gstreamer 1.0 API of the frei0r plugins (except frei0r mixer)

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=681678
  GStreamer | gst-plugins-bad | git

Olivier Crete (Tester) <olivier.crete> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #225237|none                        |needs-work
             status|                            |

--- Comment #10 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2012-09-27 23:51:38 UTC ---
Review of attachment 225237:
 --> (https://bugzilla.gnome.org/review?bug=681678&attachment=225237)

::: gst/frei0r/gstfrei0rmixer.c
@@ +183,2 @@
+    caps = gst_pad_get_current_caps (self->src);
+    caps = gst_pad_get_pad_template_caps (self->src);

Reference leak!

::: gst/frei0r/gstfrei0rsrc.c
@@ +76,3 @@
+  GST_BUFFER_DURATION (buf) =
+      gst_util_uint64_scale (self->n_frames, GST_SECOND * self->info.fps_d,
+      self->info.fps_n) - GST_BUFFER_TIMESTAMP (buf);

shouldn't duration just be: gst_util_uint64_scale (GST_SECOND,
self->info.fps_d, self->fps_n); ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.