[Bug 684981] Pipeline hangs on PREROLLING negotiating caps
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Sat Sep 29 06:45:49 PDT 2012
https://bugzilla.gnome.org/show_bug.cgi?id=684981
GStreamer | gstreamer (core) | 1.0.0
Tim-Philipp Müller <t.i.m> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
Target Milestone|HEAD |1.0.1
--- Comment #6 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2012-09-29 13:45:43 UTC ---
I think it's the right thing to do as well, and I hope the positive effects of
keeping the list small right away will outweigh the negatives overall:
commit 507fc9cea7d587446fba08dfeac7e063e14c680e
Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date: Sat Sep 29 14:35:58 2012 +0100
value: avoid duplicates when intersecting lists
Fixes negotiation taking a ridiculous amount of
time (multiple 10s of seconds on a core2) when
there are duplicate entries in lists.
Could have a negative performance impact on other
scenarios because we now have to iterate the
dest list to avoid duplicates, but we don't
have a lot of lists any more these days, and
they tend to be small anyway. The negatives
are hopefully countered by the positive effects
of reducing the list length early on in the
process. And in any case, it's the right thing
to do.
Based on patch by Andre Moreira Magalhaes.
https://bugzilla.gnome.org/show_bug.cgi?id=684981
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list