[Bug 667222] dvdspu: use refcounting instead of explicit copy

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=667222
  GStreamer | gst-plugins-bad | git

Jan Schmidt <thaytan> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thaytan at mad.scientist.com

--- Comment #4 from Jan Schmidt <thaytan at mad.scientist.com> 2012-09-30 10:50:40 UTC ---
I think I made it take a copy rather than store a reference to the sink
allocated buffer when dvdspu is about to draw an overlay. Storing a ref, just
makes it do a copy in gst_buffer_make_writable, which would then make the
downstream buffer be a normal memory buffer, and force a copy in the sink in
the common case. This way, the copy in the sink happens in the uncommon case of
duplicating a reference frame for a DVD still sequence.

In the case of no dvdspu overlay, it just pushes the buffer downstream and
stores a ref rather than a copy.

Another fix might be to actually make dvdspu allocate downstream when it needs
to dup a frame for writability.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.