[Bug 697060] New: This patch extracts the offset and stride information, if present, =?UTF-8?Q?=20from=20the=20buffer=E2=80=99s=20metadata=20and=20fills=20in=20the=20GstVideoCodecState=20state=20structure?=.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=697060
  GStreamer | gst-plugins-base | 1.0.5

           Summary: This patch extracts the offset and stride information,
                    if present, from the buffer’s metadata and fills in
                    the GstVideoCodecState state structure.
    Classification: Platform
           Product: GStreamer
           Version: 1.0.5
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: jose.carballo at ridgerun.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=240320)
 View: https://bugzilla.gnome.org/attachment.cgi?id=240320
 Review: https://bugzilla.gnome.org/review?bug=697060&attachment=240320

Patch proposed to fix the problem described in this issue.

[1] gst-plugins-good-1.0.5:

The function gst_v4l2_buffer_pool_alloc_buffer() (file gstv4l2bufferpool.c) has
the ability to set the stride and offset metadata of a buffer, according to the
bytes per line information obtained by the capture driver through
gst_v4l2_object_set_format() (file gstv4l2object.c).

[2] gst-plugins-base-1.0.5:

The GstVideoEncoder class (file gstvideoencoder.c), in function
gst_video_encoder_setcaps(), do not use the metadata associated with the buffer
(see [1]) to fill the state (GstVideoCodecState) structure.

We discovered this problem when working with a capture driver that provides
lines aligned to 32 bits. For example, for NV12, on a resolution of width 720
(not multiple of 32), the driver would return 736 (multiple of 32) bytes per
line, so the stride/offset need to be set according to these particular values,
and not just according to the video format, width, and height, which is what is
currently being done (see fill_planes() in file video-info.c).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.