[Bug 697060] videoencoder: extract offset and strides from the buffer’s GstVideoMeta if present

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=697060
  GStreamer | gst-plugins-base | 1.0.5

--- Comment #2 from Jose P. Carballo <jose.carballo at ridgerun.com> 2013-04-04 15:47:51 UTC ---
What we think is that is just a difference where you get the correct stride.
With this patch, we are able to capture the correct stride in set_format(),
which is conveniently called only when configured. If we don't use the patch,
we would use handle_frame() like you suggest, but then we would get the stride
on every frame, and for efficiency, possibly need to add some logic to get the
stride only when we want to (the first frame and caps reconfiguration).

In the GstVideoEncoder documentation we read: "Base class collects input data
and metadata into a frame and hands this to subclass' handle_frame.", pretty
much what you suggested. Now we think this is the most appropriate, please let
us know if you have more comments on this matter.

The encoder is a hardware accelerated h264 custom encoder, under development by
RidgeRun (https://github.com/RidgeRun/gst-ce-plugin/).

Thanks.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.