[Bug 696549] wavparse: add 'note' chunk support
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Fri Apr 5 04:35:16 PDT 2013
https://bugzilla.gnome.org/show_bug.cgi?id=696549
GStreamer | gst-plugins-good | git
Stefan Sauer (gstreamer, gtkdoc dev) <ensonic> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #239928|none |reviewed
status| |
--- Comment #3 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2013-04-05 11:35:12 UTC ---
Review of attachment 239928:
--> (https://bugzilla.gnome.org/review?bug=696549&attachment=239928)
Looks good to me.
::: gst/wavparse/gstwavparse.c
@@ +1252,3 @@
+ note->cue_point_id = GST_READ_UINT32_LE (data);
+ note->text = (gchar *) g_new0 (gchar *, size - 4 + 1);
+{
you can use g_memdup() here to allocate and dup in one go.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list