[Bug 697103] [PATCH] osxaudio: port to 1.0

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=697103
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #240390|none                        |needs-work
             status|                            |

--- Comment #10 from Sebastian Dröge <slomo at circular-chaos.org> 2013-04-06 19:16:56 UTC ---
Review of attachment 240390:
 --> (https://bugzilla.gnome.org/review?bug=697103&attachment=240390)

Looks good in general, just some minor problems:

::: sys/osxaudio/gstosxaudiosink.c
@@ +160,3 @@
+G_DEFINE_TYPE_WITH_CODE (GstOsxAudioSink, gst_osx_audio_sink,
+    GST_TYPE_AUDIO_BASE_SINK,
+    gst_osx_audio_sink_do_init (GST_TYPE_AUDIO_BASE_SINK));

The GType is available here as g_define_type_id. You pass the wrong type to the
function here

@@ +556,3 @@
       switch (layout->mChannelDescriptions[i].mChannelLabel) {
         case kAudioChannelLabel_Left:
+          channel_mask |= GST_AUDIO_CHANNEL_POSITION_MASK (FRONT_LEFT);

This is not correct, you need to tell the ringbuffer the OSX specific channel
order with gst_audio_ring_buffer_set_channel_positions() additional to that
mask
See existing usage of that function

::: sys/osxaudio/gstosxaudiosrc.c
@@ +126,3 @@
+G_DEFINE_TYPE_WITH_CODE (GstOsxAudioSrc, gst_osx_audio_src,
+    GST_TYPE_AUDIO_BASE_SRC,
+    gst_osx_audio_src_do_init (GST_TYPE_AUDIO_BASE_SRC));

Same here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.