[Bug 697103] [PATCH] osxaudio: port to 1.0

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=697103
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #241165|none                        |needs-work
             status|                            |

--- Comment #17 from Sebastian Dröge <slomo at circular-chaos.org> 2013-04-10 14:46:13 UTC ---
Review of attachment 241165:
 --> (https://bugzilla.gnome.org/review?bug=697103&attachment=241165)

::: sys/osxaudio/gstosxaudioringbuffer.c
@@ +237,3 @@
+  gst_structure_get (s, "channel-mask", GST_TYPE_BITMASK, &channel_mask,
NULL);
+  gst_audio_channel_positions_from_mask (channels, channel_mask, positions);
+  gst_audio_ring_buffer_set_channel_positions (buf, positions);

This is still not correct, you should pass an array of the order of the channel
positions as they're used in OSX. What you pass here is the order used in
GStreamer, which is most probably not the same.

Otherwise, this is now called in the right place and all that :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.