[Bug 696714] wavenc: add 'note' chunk support

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=696714
  GStreamer | gst-plugins-good | git

Stefan Sauer (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #239999|none                        |needs-work
             status|                            |

--- Comment #4 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2013-04-11 07:24:53 UTC ---
Review of attachment 239999:
 --> (https://bugzilla.gnome.org/review?bug=696714&attachment=239999)

A few small comments. Looks good otherwise. Thanks.

::: gst/wavenc/gstwavenc.c
@@ +638,2 @@
 static gboolean
+gst_wavenc_check_cue_id (guint32 id, GList * list)

rename to gst_wavenc_is_cue_id_unique() ?

@@ +661,3 @@
+  gst_toc_entry_get_start_stop_times (entry, &start, NULL);
+
+  cue = g_new0 (GstWavEncCue, 1);

just use g_new(GstWavEncCue, 1); when you initialize all fields

@@ +687,3 @@
+      return FALSE;
+  }
+  return TRUE;

here too.

@@ +712,3 @@
+  }
+
+  if (tags != NULL) {

and here too.

@@ +855,3 @@
+      cues_size += 24;
+      list = g_list_next (list);
+    }

cues_size += 24 * g_list_length(wavenc->cues);

also below.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.