[Bug 697806] avdec_h264 Fails during error recovery after packet loss leading to stream corruption

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=697806
  GStreamer | gst-libav | 1.0.5

--- Comment #7 from tcdgreenwood at hotmail.com 2013-04-15 11:15:28 UTC ---
Sebastian - thanks so much for looking at the patch.  I hope that I'm helping
by submitting these patches - I feel that perhaps I'm taking up quite a bit of
people's time on bugs, patches and IRC (especially where I don't understand
things yet etc).

On the first point (patching reget) - I'll be happy to try and fix the first
point at some time, but there are only so many hours in the day and it seemed a
minor performance issue.  I thinking that rather than fixing this a better
patch would be to move to using the new get_buffer2 APIs on libav.  I think I
just about understand this enough to be able to do that.  Would it be helpful
if I did that?  Are there any plans to move to the new APIs?

Second point (printing opaque) - I should have removed picture->opaque from
that debug, I was printing it because it should have been NULL but wasn't when
libav called into get_buffer really this was just part of me working out how it
seemed to be getting opaque back from no where.  I'll rework the patch for
this.

Third point (missing av_free) - I'll think about this I think you are right
about the free being mismatched.  Good job I've got someone looking at what I'm
doing!

It may take me a could of days to work through this and get the patch right as
I have to work!

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.