[Bug 697103] [PATCH] osxaudio: port to 1.0

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=697103
  GStreamer | gst-plugins-good | git

--- Comment #29 from Todd Agulnick <todd at agulnick.com> 2013-04-15 17:28:43 UTC ---
Review of attachment 241577:
 --> (https://bugzilla.gnome.org/review?bug=697103&attachment=241577)

Nakajima-san,

I was wondering too about the timing of caps requests and the transition from
the null to ready state (which I think is when the ring buffer gets created).
I'm surprised to hear that the caps queries happen first.

-Todd

P.S. Gomen nasai about my earlier advice; I'm still trying to under the caps
negotiation protocol.

::: sys/osxaudio/gstosxaudioringbuffer.c
@@ +229,3 @@
       CORE_AUDIO_FORMAT_ARGS (format));

+  osxsink = GST_OSX_AUDIO_SINK (GST_OBJECT_PARENT (buf));

This osxringbuffer is used by both the osxaudiosrc as well as the osxaudiosink.
So I think this code will fail in the src case.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.