[Bug 690719] jackaudiosink: add new property (port-pattern) to specify which jack ports to autoconnect to

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=690719
  GStreamer | gst-plugins-good | 0.10.31

Stefan Sauer (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #232218|none                        |rejected
             status|                            |

--- Comment #2 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2013-04-20 18:43:04 UTC ---
Review of attachment 232218:
 --> (https://bugzilla.gnome.org/review?bug=690719&attachment=232218)

Could you rebase the patch for 1.0? Also what about the src?

::: gst-plugins-good0.10-0.10.31/ext/jack/gstjackaudiosink.c
@@ +464,3 @@
+            ports = jack_get_ports (client, sink->port_pattern, NULL,
+                JackPortIsInput);
+    }

why are you dropping JackPortIsPhysical when using a pattern. I think this
would be worth a discussion in general (or controlled by a separate flag).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.