[Bug 646963] rtpmanager: Only update last_rtcp_send_time when actually sending a report

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sun Apr 21 23:30:58 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=646963
  GStreamer | gst-plugins-good | git

--- Comment #4 from Pascal Buhler <pabuhler at cisco.com> 2013-04-22 06:30:54 UTC ---
This patch maybe missing some context, but going on memory the idea was that
last_rtcp_send_time should only be updated when a full packet (ie one that
contain full SR/RR's) is being sent. This was definitely someting added after
we did some support for minimal RTCP packets so with out that change it is
maybe irreverent.

I would also agree that updating last_rtcp_send_time should happen only if the
packet was actually sent.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list