[Bug 690515] [PATCH] Bash tab-completion for gst-launch pipeline

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=690515
  GStreamer | gstreamer (core) | git

--- Comment #14 from David Röthlisberger <david at rothlis.net> 2013-04-22 14:57:32 UTC ---
> Could you squash the patch into one?

Any particular reason not to commit it as 5 separate commits? I think
that there's a lot of documentation value in the incremental approach
taken by the patch series, and in particular in the commit messages; if
someone wonders "why is this line like this" they can use `git annotate`
and see "oh right, it's for compatibility with bash 3" or whatever. This
is particularly important for the `case` statements in
`_gst_launch_parse` because they can be rather cryptic.

+ Patch #1 fixes the previous non-working behaviour, and makes diff #2
  clearer.

+ Patch #2 is the bulk of the implementation.

+ Patch #3 & #4 are bash 3 compatibility fixes that add a fair amount of
  complexity. Apart from the above reasons, there is extra value to
  having them as separate commits, so that we can revert them if we ever
  choose to drop bash 3 support.

If you want atomicity, you could add the 5 commits on a branch and do a
git "non-fast-forward" merge (git merge --no-ff) to create a merge
commit.

Obviously the final decision is with you, the maintainers; but as the
author I would prefer that the public commit history reflect my
documentation philosophy.

Anyway, thanks for looking into this & testing it! I'm excited, my first
patches to make it into GStreamer. :-)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.