[Bug 698562] gstrtpbuffer.c: broken language bindings for gst_rtp_buffer_get_payload

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=698562
  GStreamer | gst-plugins-base | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |t.i.m at zen.co.uk
     Ever Confirmed|0                           |1
           Severity|normal                      |enhancement

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2013-04-23 22:37:26 UTC ---
Ok, some nitpicks, and some things I'm not sure about yet:

 - please add 'Since: 1.2' markers for new API

 - the old functions that we're replacing via
    Rename-to should probably be marked with
    (skip) or so

 - if these functions are for bindings, it might
   be better to just return const guint8 * or
   guint8 * directly instead of gpointer plus
    annotating the pointer

 - the out length argument should probably
    be gsize now instead of guint. We haven't
    changed it everywhere, but we may just
    as well do it right in new API even if it
    doesn't really make a difference.

 - this whole 'the returned memory is valid
    as long as the object is valid' thing does
    not work too well for bindings, I don't
    think we can express that. I believe
    bindings will work around that by just
    making a copy of the bytes in any case.
    The main implication here is that this
    works fine for reading, but will very likely
    not work for writing at all (since the
    bindings will modified the copied buffer
    and not the original one). I'm guessing
    you are only reading data here?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.