[Bug 611157] [RFC] more buffer flags and caps fields in gst-video for 3d video

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=611157
  GStreamer | gst-plugins-base | unspecified

--- Comment #61 from Sebastian Dröge <slomo at circular-chaos.org> 2013-04-24 13:09:46 UTC ---
Review of attachment 241093:
 --> (https://bugzilla.gnome.org/review?bug=611157&attachment=241093)

::: gst-libs/gst/video/video-stereo.c
@@ +69,3 @@
 };

+static StereoFrameLayout sf_layouts[] = {

constify

@@ +114,3 @@
+
+GstStereoVideoFrameLayout
+get_stereo_frame_layout_from_string (const gchar * s)

_to_string() variants too maybe

::: gst-libs/gst/video/video-stereo.h
@@ +133,3 @@
+  /* Caps doesn't have field for flipping flags */
+  gboolean h_flipped;
+  gboolean v_flipped;

Padding missing

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.