[Bug 698712] playbin: autoplug video decoder and sink based on caps features

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=698712
  GStreamer | gst-plugins-base | git

--- Comment #12 from Sebastian Dröge <slomo at circular-chaos.org> 2013-04-24 13:35:31 UTC ---
(In reply to comment #11)
> @@ +3797,3 @@
> +          GST_SOURCE_GROUP_LOCK (group);
> +          gst_element_set_state (group->video_sink, GST_STATE_NULL);
> +          gst_object_unref (group->video_sink);
> 
> Why do you destroy the previously selected sink here?
> 
> I think the previous explanation is enough..right? :)
> If the created sink is not compatible with the factory, then unref the sink and
> make sure that there is no more factory:video_sink combination in the velements
> list before returning GST_AUTOPLUG_SELECT_SKIP.

Yes, but why isn't the loop like this without all the diry flags?

for (l = velements; l; l = l->next) {
  if (l->data->vdec != factory)
    continue;
  current_code;
}

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.