[Bug 698712] playbin: autoplug video decoder and sink based on caps features

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=698712
  GStreamer | gst-plugins-base | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #242415|none                        |needs-work
             status|                            |

--- Comment #16 from Sebastian Dröge <slomo at circular-chaos.org> 2013-04-25 14:01:06 UTC ---
Review of attachment 242415:
 --> (https://bugzilla.gnome.org/review?bug=698712&attachment=242415)

Looks almost good

::: gst/playback/gstplaybin2.c
@@ +293,3 @@
+typedef struct
+{
+  GstElementFactory *dec;       /* audo:video decoder */

Typo: audo

@@ +323,3 @@

+  GList *aelements;             /* a list of GstAVElements for audio stream */
+  GList *velements;             /* a list of GstAVElements for video stream */

Why don't you store it inside GstPlayBin, and create it at the same time as the
other elements list?

@@ +3527,3 @@
+    GST_SOURCE_GROUP_LOCK (group);
+    /* create the audio/video element list */
+    *ave_list = create_avelements_list (factory_list, sink_list);

IMHO this should be done at a central place and not inside the autoplug
callbacks, similar to the other elements list

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.