[Bug 699099] New: Should remove calling gst_rtsp_media_unprepare() in gst_rtsp_client_finalize()

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=699099
  GStreamer | gst-rtsp-server | git

           Summary: Should remove calling gst_rtsp_media_unprepare() in
                    gst_rtsp_client_finalize()
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-rtsp-server
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: zhuoyc at 126.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


In gst-rtsp-server, I run test-uri to test.

I set the shared property to TRUE in order to allow multiple clients to see the
same video. In this scenario, when one of clients stops, below error logs
occur. These error logs are introduced by calling gst_rtsp_media_unprepare() in
rtsp-client.c: gst_rtsp_client_finalize(). 

This proc calling is added in fixing Bug 688707. 

Suggest remove calling gst_rtsp_media_unprepare() in gst_rtsp_client_finalize()
because unprepare() will be called by gst_rtsp_media_finalize() when reference
count is zero. Just call unref(media) in gst_rtsp_client_finalize() should be
enough.

-------------------LOG---------------------

** CRITICAL **: gst_rtsp_stream_leave_bin: assertion `stream->transports ==
NULL' failed

** CRITICAL **: gst_rtsp_stream_finalize: assertion `!stream->is_joined' failed

GStreamer-CRITICAL **:
Trying to dispose element udpsrc10, but it is in PLAYING (locked) instead of
the NULL state.
You need to explicitly set elements to the NULL state before dropping the final
reference, to allow them to clean up. This problem may also be caused by a
refcounting bug in the application or some element.


GStreamer-CRITICAL **:
Trying to dispose element udpsrc9, but it is in PLAYING (locked) instead of the
NULL state.
You need to explicitly set elements to the NULL state before dropping the final
reference, to allow them to clean up. This problem may also be caused by a
refcounting bug in the application or some element.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.