[Bug 699187] videorate ends up outputting buffers with incorrect duration.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=699187
  GStreamer | gst-plugins-base | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #242758|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge <slomo at circular-chaos.org> 2013-04-29 08:51:15 UTC ---
Review of attachment 242758:
 --> (https://bugzilla.gnome.org/review?bug=699187&attachment=242758)

::: gst/videorate/gstvideorate.c
@@ +616,1 @@
         videorate->base_ts + gst_util_uint64_scale
(videorate->out_frame_count,

I'm not sure this is correct in general. If videorate would be outputting a
single segment and everything timestampped to running time it would be correct,
but AFAUI videorate doesn't do that. Instead it generates timestamps inside the
configured segment and closes gaps, etc.

As such the segment base should not be considered for buffer timestamps but
kept in the downstream segment.

@@ +725,3 @@
+
+      /* Our new base for interpolation is now the segment base */
+      videorate->base_ts = videorate->segment.base;

5 lines (or so) above base_ts is set to 0. I think the line setting it to 0
should be removed if all this is correct

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.