[Bug 698854] [applemedia] Several improvements for the applemedia plugins

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=698854
  GStreamer | gst-plugins-bad | 1.x

--- Comment #5 from Andoni Morales <ylatuya at gmail.com> 2013-04-29 11:29:04 UTC ---
(In reply to comment #4)
> 
> https://github.com/ylatuya/gst-plugins-bad/commit/565455fc12a1aaa38e20897aa9f82e4665abfcc4
> 
> Is it guaranteed that we always get a callback for each buffer we pass to the
> decode function? Looks good to me but I'm worried about buffer leaks here.
> Would be less of a problem if GstVideoDecoder was used, then you could just
> pass the frame ID there and the buffer is not really lost and can be garbage
> collected later.
> 

I moved back the unref of the input buffer to decode_buffer () :)
https://github.com/ylatuya/gst-plugins-bad/blob/908d9fb1d81503a8d25c95684ac0a61ae00dc99a/sys/applemedia/vtdec.c#L484

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.