[Bug 698712] playbin: autoplug video decoder and sink based on caps features
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Mon Apr 29 12:44:33 PDT 2013
https://bugzilla.gnome.org/show_bug.cgi?id=698712
GStreamer | gst-plugins-base | git
Sebastian Dröge <slomo> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #242835|none |reviewed
status| |
--- Comment #55 from Sebastian Dröge <slomo at circular-chaos.org> 2013-04-29 19:44:28 UTC ---
Review of attachment 242835:
--> (https://bugzilla.gnome.org/review?bug=698712&attachment=242835)
Looks good, I'll push this tomorrow after some testing. Just some comments
below
::: gst/playback/gstplaybin2.c
@@ +3447,3 @@
+ n_common_cf = get_n_common_capsfeatures (d_factory, s_factory);
+ if (n_common_cf < 1)
+ continue;
For the optimization idea this should be < 2 or <= 1. There will always be one
in common: system memory. And it is 0 only if there are no compatible caps at
all
@@ +3818,3 @@
+ ave = (GstAVElement *) tmp->data;
+ if (ave->dec != factory)
+ continue;
For the optimization idea the decoder might not be in the list, but the code
below should still happen (the check if the already selected sink works or
not).
@@ +3902,3 @@
}
/* it's a sink, see if an instance of it actually works */
And here is another part of the magic sink selection that is already there, we
get here for sinks that support an encoded stream.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list