[Bug 698927] LADSPA improved port to gstreamer 1.0
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Mon Apr 29 23:31:18 PDT 2013
https://bugzilla.gnome.org/show_bug.cgi?id=698927
GStreamer | gst-plugins-bad | git
--- Comment #5 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2013-04-30 06:31:01 UTC ---
_get_type() function are normally needed if you instantiate GObjects through a
know GType (e.g. g_object_new(GST_LADSPA_SOURCE, ...); ). This is not the case
in GStreamer. All the plugins register elements into a name:gtype map. Later
elements can be created from the GstElementFactory by name. In the ladspa case,
we would need a new get_type() function for each element that we wrap. This
does not scale. Thus in ladspa_describe_source_plugin() we create a new gtype
and register it. This we can repeat for many <name,gtype> pairs.
Regarding gstmyutils:
It contains 3 functions. Please move them to gstladspa{source,filter,sink}.c as
static helpers respectively.
Regarding the module:
It is okay for plugins to 'leak' a one-time allocation. This will be freed when
the application exits. When the plugins are scanned for the first time, this is
done from a separate process to not impose the memory overhead on the calling
application (among other reasons). Please remove the use of the type module.
You can add a comment to such allocations and tell that it is a one time
allocation that is not freed. We do have this in other wrapper plugins too.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list