[Bug 705079] hlsdemux: switch fragments to buffer lists to avoid copies

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Aug 1 07:35:27 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=705079
  GStreamer | gst-plugins-bad | 1.1.2

Arnaud Vrac <rawoul> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #250372|0                           |1
        is obsolete|                            |

--- Comment #3 from Arnaud Vrac <rawoul at gmail.com> 2013-08-01 14:35:21 UTC ---
Created an attachment (id=250627)
 View: https://bugzilla.gnome.org/attachment.cgi?id=250627
 Review: https://bugzilla.gnome.org/review?bug=705079&attachment=250627

uridownloader: use buffer lists to store fragments

I've taken another approach on this:

GstFragment now uses GstBufferList to store data, but I've kept the
gst_fragment_get_buffer function for compatibility and simplicity. This
function now merges all the buffers in the buffer list in one single buffer.
This avoids copying all data while accumulating the memory blocks, the data is
only copied once in the end.

The improvement can be seen when running with GST_CAT_PERFORMANCE:5 logging,
much less copies happen.

Note that the typefinding issue is still there, although it is less likely to
happen since the first buffer now contains 16 memory blocks.

I also have patches that updates the demuxers to use buffer lists directly when
possible, that I might send later.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list