[Bug 705598] New: regression h264parse: incorrect keyframe/delta-unit detection

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=705598
  GStreamer | gst-plugins-bad | git

           Summary: regression h264parse: incorrect keyframe/delta-unit
                    detection
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: NEW
          Severity: blocker
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: bilboed at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


In the legacy h264parser (pre-baseparse), detecting whether a frame/buffer was
a delta-unit or not was based on the slice_type whereas in the new parser it is
based on whether the input contains a SPS or PPS or IDR.

The new behaviour is wrong since you can have streams that have new PPS on
every frame, resulting in all output buffers being marked as keyframes.

The previous (correct) behaviour was to check the slice_type, and if it was
2,4,7 or 9 it was considered as a keyframe, else as a delta unit.

Amongst other things this breaks (re)muxing of h264 in matroska (all frames are
considered keyframes and only one cue/index entry is created).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.