[Bug 705415] [gio] incredibly inefficient when playing mp3s from smb servers

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=705415
  GStreamer | gst-plugins-base | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #250775|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-08-08 09:39:35 UTC ---
Review of attachment 250775:
 --> (https://bugzilla.gnome.org/review?bug=705415&attachment=250775)

Looks good generally just:

::: gst/gio/gstgiobasesrc.c
@@ +372,3 @@
      * at least the requested amount of bytes or a read returns
      * nothing. */
+    mem = gst_allocator_alloc (NULL, cachesize - read, NULL);

I think it makes sense to still read cachesize bytes. Otherwise you might end
up reading just a byte or two here which is a bit inefficient when going
through e.g. gvfs

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.