[Bug 705621] baseparse: Add a property to force processing

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Aug 8 03:35:23 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=705621
  GStreamer | gstreamer (core) | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #251088|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-08-08 10:35:20 UTC ---
Review of attachment 251088:
 --> (https://bugzilla.gnome.org/review?bug=705621&attachment=251088)

::: libs/gst/base/gstbaseparse.c
@@ +790,3 @@
   parse->priv->next_dts = 0;
   parse->priv->syncable = TRUE;
+  parse->priv->force_processing = FALSE;

= DEFAULT_FORCE_PROCESSING

@@ +3506,3 @@
+  /* Only change passthrough mode if we're not forcing processing */
+  if (!parse->priv->force_processing)
+    parse->priv->passthrough = passthrough;

I think it's better to instead always store the passthrough value and
everywhere where it is used use "!force_processing && passthrough"

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list