[Bug 705694] [dataqueue] add gst_data_queue_push_force

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Aug 8 10:54:46 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=705694
  GStreamer | gstreamer (core) | unspecified

--- Comment #1 from Thiago Sousa Santos <thiago.sousa.santos at collabora.co.uk> 2013-08-08 17:54:39 UTC ---
Created an attachment (id=251205)
 View: https://bugzilla.gnome.org/attachment.cgi?id=251205
 Review: https://bugzilla.gnome.org/review?bug=705694&attachment=251205

dataqueue: add gst_data_queue_push_force

Adds a variant of the _push function that doesn't check the queue limits
before adding the new item. It is useful when pushing an element to the
queue shouldn't lock the thread.

One particular scenario is when the queue is used to serialize buffers
and events that are going to be pushed from another thread. The
dataqueue should have a limit on the amount of buffers to be stored to
avoid large memory consumption, but events can be considered to have
negligible impact on memory compared to buffers. So it is useful to be
used to push items into the queue that contain events, even though the
queue is already full, it shouldn't matter inserting an item that has
no significative size.

This scenario happens on adaptive elements (dashdemux / mssdemux) as
there is a single download thread fetching buffers and putting into the
dataqueues for the streams. This same download thread can als generate
events in some situations as caps changes, eos or a internal control
events. There can be a deadlock at preroll if the first buffer fetched
is large enough to fill the dataqueue and the download thread and the
next iteration of the download thread decides to push an event to this
same dataqueue before fetching buffers to other streams, if this push
locks, the pipeline will be stuck in preroll as no more buffers will be
downloaded.
There is a somewhat common practice in dash streams to have a single
very large buffer for audio and one for video, so this will always
happen as the download thread will have to push an EOS right after
fetching the first buffer for any stream.

API: gst_data_queue_push_force

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list