[Bug 615740] aacparse: Add conversion support from/to ADIF/ADTS/RAW/LOAS stream-formats

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=615740
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #251341|none                        |needs-work
             status|                            |

--- Comment #30 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-08-13 09:01:00 UTC ---
Review of attachment 251341:
 --> (https://bugzilla.gnome.org/review?bug=615740&attachment=251341)

Looks almost good, just some nitpicks :)

::: gst/audioparsers/gstaacparse.c
@@ +967,3 @@
+  srccaps = gst_pad_get_current_caps (GST_BASE_PARSE_SRC_PAD (aacparse));
+  srcstruct = gst_caps_get_structure (srccaps, 0);
+  profile = gst_structure_get_value (srcstruct, "profile");

gst_structure_get_string(), and if it's not successful or NULL return

@@ +1079,3 @@
+  gsize frame_size;
+  guint8 id, profile, channel_configuration, sampling_frequency_index;
+  const gsize adts_headers_length = 7UL;        /* Total byte-length of fixed

Maybe make this a #define

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.