[Bug 705832] eglglesink: support window handle changes in PAUSED

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=705832
  GStreamer | gst-plugins-bad | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #251340|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-08-13 10:31:15 UTC ---
Review of attachment 251340:
 --> (https://bugzilla.gnome.org/review?bug=705832&attachment=251340)

Why would you like to support changing the window in PAUSED? It's not supported
by any of the other video sinks right now (except for glimagesink).

Also eglglessink is going to go away sooner or later, to be replaced by
gst-plugins-gl.

::: ext/eglgles/gsteglglessink.c
@@ +959,3 @@
+  }
+  /* We also need a new VBO */
+  eglglessink->render_region_changed = TRUE;

Note that all this happens neither from the streaming thread nor the GL thread.
Stuff might crash in interesting ways if you clean up everything here at random
times, while rendering still happens for example.

I think you should store the newly set window only here, and next time the
streaming thread or GL thread is called you compare the current window to the
set window, and if they differ reconfigurate whatever is necessary.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.