[Bug 705189] debug-dot-dump: Add the presence/state of a GstTask

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=705189
  GStreamer | gstreamer (core) | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #250521|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-08-13 12:43:48 UTC ---
Review of attachment 250521:
 --> (https://bugzilla.gnome.org/review?bug=705189&attachment=250521)

Good idea, I don't really have an opinion how it should be displayed though.
Should be good enough that way I guess?

::: gst/gstdebugutils.c
@@ +169,3 @@
+    GST_OBJECT_LOCK (pad);
+    task = GST_PAD_TASK (pad);
+    GST_OBJECT_UNLOCK (pad);

Maybe take a new reference of the task here?

@@ +179,3 @@
+          break;
+        default:
+          g_assert_not_reached ();

This should probably not assert here, but instead silently do nothing

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.