[Bug 705024] aacparse: does not propagate downstream sample rate restriction upstream

Tue Aug 13 05:56:09 PDT 2013

https://bugzilla.gnome.org/show_bug.cgi?id=705024
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at circular-chaos.org

--- Comment #5 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-08-13 12:56:04 UTC ---
I was told that this was introduced by this commit:

commit ca4b5d795bf52ea434470475e2dac6a149282c10
Author: Sebastian Dröge <sebastian.droege at collabora.co.uk>
Date:   Tue Jun 5 09:18:12 2012 +0200

    audioparsers: Fix GstBaseParse::get_sink_caps() implementations

    They should take the filter caps into account and always return
    the template caps appended to the actual caps. Otherwise the
    parsers stop to accept unparsed streams where upstream does not
    know about channels, rate, etc.

    Fixes bug #677401.

The problem here is that if downstream has rate=44100 as a constraint we would
need to pass that upstream. However we can't pass that constraint upstream
because unparsed AAC streams might not have the rate on the caps.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.