[Bug 705870] [audiobasesink] add callback for custom logic based on the sink's average skew value

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=705870
  GStreamer | gst-plugins-base | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #251421|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-08-13 13:14:41 UTC ---
Review of attachment 251421:
 --> (https://bugzilla.gnome.org/review?bug=705870&attachment=251421)

::: gst-libs/gst/audio/gstaudiobasesink.h
@@ +104,2 @@
 /**
+ * GstAudioRingBufferCallback:

Shouldn't this instead be a vfunc inside the class? Isn't it class specific?
Also shouldn't it somehow circumvent the existing skew logic?

@@ +106,3 @@
+ * @rbuf: a #GstAudioRingBuffer
+ * @data: (array length=len): target to fill
+ * @len: amount to fill

Copy&paste mistake in the docs

@@ +218,3 @@
+                                                        GstClockTime
threshold,
+                                                       
GstAudioBaseSinkAvgSkewCallback callback,
+                                                        gpointer user_data);

Needs a GDestroyNotify for the user_data

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.