[Bug 691462] typefind ADTS/AAC wrongly detected as MP2

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=691462
  GStreamer | gst-plugins-base | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #251583|none                        |needs-work
             status|                            |

--- Comment #8 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-08-14 09:14:52 UTC ---
Review of attachment 251583:
 --> (https://bugzilla.gnome.org/review?bug=691462&attachment=251583)

Can you attach this in "git format-patch" format?

::: gst/typefind/gsttypefindfunctions.c
@@ +1036,3 @@
+        offset += len;
+
+        /* find more aac sync to select correctly */

I think it would be better to move this into a loop instead of duplicating the
same code 3 times. Also I think if we found that many frames in the correct
distances it is safe to give maximum probability :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.