[Bug 657343] [patch] small changes to mpegtsmux

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=657343
  GStreamer | gst-plugins-bad | git

--- Comment #42 from Stas Sergeev <stsp at list.ru> 2013-08-14 12:15:47 UTC ---
(In reply to comment #41)
> Not cool really. I was expecting you were relying on specifications instead of
> guessing what's going on based on misc code.
Do you really expect me to remember the specification 2
years after I made the patch?

Anyway, the iso13818-1 says this:
---
if ( PES_extension_flag_2 == '1') {
  marker_bit
  PES_extension_field_length
  for (i = 0; i < PES_extension_field_length; i++) {
    reserved
  }
}
---

But the document you point to, says this:
---
if ( PES_extension_flag_2 == '1') {
  marker_bit
  PES_extension_field_length
  stream_id_extension_flag
  If ( stream_id_extension_flag == '0') {
    stream_id_extension
  }
  else {
---

It is up to you to decide what document is right, but
accusing me in guessing on a misc code is not correct.
This "misc code" is from your git, and the standard is
from ISO.

Note that your document is messed up in that point.
It has this a few lines below:
---
    for (i = 0; i < PES_extension_field_length; i++) {
      reserved
    }
}
      }
---
Here, the closing brackets are messed (page 35), so I
wouldn't trust that part at all.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.