[Bug 705832] eglglesink: support window handle changes in PAUSED

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=705832
  GStreamer | gst-plugins-bad | unspecified

--- Comment #5 from Andoni Morales <ylatuya at gmail.com> 2013-08-14 15:22:36 UTC ---
(In reply to comment #2)
> Review of attachment 251340 [details]:
> 
> Why would you like to support changing the window in PAUSED? It's not supported
> by any of the other video sinks right now (except for glimagesink).
> 
> Also eglglessink is going to go away sooner or later, to be replaced by
> gst-plugins-gl.
> 
> ::: ext/eglgles/gsteglglessink.c
> @@ +959,3 @@
> +  }
> +  /* We also need a new VBO */
> +  eglglessink->render_region_changed = TRUE;
> 
> Note that all this happens neither from the streaming thread nor the GL thread.
> Stuff might crash in interesting ways if you clean up everything here at random
> times, while rendering still happens for example.
> 
> I think you should store the newly set window only here, and next time the
> streaming thread or GL thread is called you compare the current window to the
> set window, and if they differ reconfigurate whatever is necessary.

That should be easily integrated with #705831 to track window changes and delay
full reconfigurations in the correct thread.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.