[Bug 705999] taglist: handle publisher, interpreted-by and key tags

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Aug 15 01:02:44 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=705999
  GStreamer | gstreamer (core) | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #251620|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-08-15 08:02:42 UTC ---
Review of attachment 251620:
 --> (https://bugzilla.gnome.org/review?bug=705999&attachment=251620)

There seems to be some overlap between composer, performer and interpreted-by
somehow. Not sure

::: gst/gsttaglist.h
@@ +1062,3 @@
+ * Musical key in which the sound starts (string with maximum length of 3)
+ */
+#define GST_TAG_KEY                               "key"

This one should be in libgsttag in gst-plugins-base as it's media specific.
Also just calling it KEY is a bit too generic. Also list examples of how it
should look like or reference a standard. I assume this is something like "C3",
"C#3", ie http://en.wikipedia.org/wiki/Scientific_pitch_notation?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list