[Bug 705993] aiffparse: fix push mode / add tests

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=705993
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #251615|none                        |reviewed
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-08-15 08:23:24 UTC ---
Review of attachment 251615:
 --> (https://bugzilla.gnome.org/review?bug=705993&attachment=251615)

::: tests/check/elements/aiffparse.c
@@ +54,3 @@
+      NULL);
+
+  fail_unless (gst_caps_is_always_compatible (caps, tcaps));

gst_caps_can_intersect() should be enough here :)

@@ +147,3 @@
+    GstBuffer ** buffer)
+{
+  if (offset + length > sizeof (aiff_file))

This could still be a short read, i.e. if offset < sizeof(aiff_file)

::: tests/check/elements/aiffparse.h
@@ +2,3 @@
+#include <glib.h>
+
+static const guint8 aiff_file[] = {

Maybe put this into a separate binary file instead of a large header?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.